[Main] Item tracking validation when lot numbers are assigned concerns the warehouse pick level rather than at the sales order levelInitial Commit - #9982
Conversation
Co-authored-by: Shikhverma <241284522+Shikhverma@users.noreply.github.com>
|
Copilot resolve the merge conflicts in this pull request |
…r-ItemTrackingValidationWhenLotNumbersAreAssigned Co-authored-by: Shikhverma <241284522+Shikhverma@users.noreply.github.com>
Resolved by merging |
…gisteredWhsePickAllocation test Co-authored-by: Shikhverma <241284522+Shikhverma@users.noreply.github.com>
Pull request was closed
Pull request was closed
Agentic PR Review - Round 7Recommendation: AcceptWhat this PR doesThis PR makes lot availability exclude quantities already committed on unregistered warehouse and inventory picks, so the same tracked lot is not double-promised to another sales demand. The core change is in The only change since round 6 is in the RU test: Status of previous suggestions
New observations (commits since round 6)No new issues found in the latest commits. The single change is a test-only setup alignment (using a location helper that also creates the inventory posting setup) and improves consistency between the RU and W1 tests. Risk assessment and necessityRisk: None added this round. The change touches only RU test setup, not the shipped item tracking logic. The data-integrity path in Necessity: The bug is valid and important: a lot already allocated on an unregistered pick could otherwise still look available. The test change is a small consistency improvement and keeps the RU location setup on par with W1.
|
Predrag Maricic (PredragMaricic)
left a comment
There was a problem hiding this comment.
S1: The new unregistered-pick request can double-count demand already represented by reservation entries. Existing item-tracking reservation entries are transferred and summarized earlier in the calculation, then every tracked unregistered pick from another source is added again at ItemTrackingDataCollection.Codeunit.al:579. In the normal source-line-tracking flow, the reservation and warehouse pick represent the same allocation, which can incorrectly make an available lot appear unavailable.
Please deduplicate the warehouse request against the transferred reservation and add a production-flow regression test that assigns source-line tracking before creating the pick. The current tests fabricate an item ledger entry and warehouse activity line without the corresponding reservation entry, so they cannot detect this interaction. All reported CI checks passed, but this remains a high-risk functional regression.
Bug 646429: [master] [REPAIR] [ALL-E] Item tracking validation when lot numbers are assigned concerns the warehouse pick level rather than at the sales order level
Fixes AB#646429